Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nki-samples updates for NeuronSDK release 2.21 #38

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

aws-qieqingy
Copy link
Contributor

Issue #, if available:

nki-samples updates associated with NeuronSDK release 2.21.

See detailed release notes at: https://awsdocs-neuron.readthedocs-hosted.com/en/latest/release-notes/index.html#neuron-2-21-0-12-20-2024

Description of changes:

  1. Use the new neuronxcc.nki.jit decorator for kernels. The old decorator torch_neuronx.nki_jit is deprecated, and will be eventually removed.
  2. Provide two samples for the new direct allocation feature. See the direct allocation developer guide for details: https://awsdocs-neuron.readthedocs-hosted.com/en/latest/general/nki/nki_direct_allocation_guide.html
  3. Restructure the source code and added Github workflow to run simulation tests
  4. Misc tests and documentation improvements

Testing:

Please see detailed unit test requirements in the CONTRIBUTING.md

  • The change is covered by numeric check using nki.baremetal
  • The change is covered by performance benchmark test using nki.benchmark
  • The change is covered by end-to-end integration test

Pull Request Checklist

  • I have filled in all the required field in the template
  • I have tested locally that all the tests pass
  • By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

Update nki-samples for NeuronSDK 2.21 Beta Release.
1. Use new nki.jit decorator for kernels.
2. Added samples for the new direct allocation feature.
3. Misc tests and documentation improvements.

Co-authored-by: aws-qieqingy <[email protected]>
* Add latest kernels and unit tests for NeuronSDK release 2.21

* Move code into src/nki_samples to make unit test executable

* Add Github workflow to run simulation tests on main branch and incoming PRs
@aws-qieqingy aws-qieqingy merged commit 05c0769 into main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants