Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing AKSK to the bedrock client #471

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

fengxu1211
Copy link
Collaborator

@fengxu1211 fengxu1211 commented Dec 5, 2024

support passing AKSK to the bedrock client for invoking LLM from another account.

🤖 AI-Generated PR Description (Powered by Amazon Bedrock)

Description

This pull request includes modifications to the configuration file for the infrastructure bin, the chat stack definition, shared types, and the Langchain integration for the online chat models. The changes aim to improve the overall functionality and performance of the chat system.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

File Stats Summary

File number involved in this PR: 4, unfold to see the details:

The file changes summary is as follows:

Files
Changes
Change Summary
source/infrastructure/lib/shared/types.ts 2 added, 0 removed The code adds optional properties bedrockAk and bedrockSk to the chat object in the SystemConfig interface.
source/infrastructure/bin/config.ts 2 added, 0 removed The code adds two new configuration properties, 'bedrockAk' and 'bedrockSk', to the chat object in the SystemConfig, likely for authentication purposes.
source/infrastructure/lib/chat/chat-stack.ts 2 added, 0 removed This code change adds environment variables for AWS access key and secret access key for Bedrock integration to the ChatStack Lambda function.
source/lambda/online/common_logic/langchain_integration/chat_models/bedrock_models.py 27 added, 8 removed The code changes add the ability to use AWS access key and secret access key from environment variables to initialize the ChatBedrockConverse model, in addition to the existing method of using a credentials profile name.

@fengxu1211 fengxu1211 requested a review from NingLu December 5, 2024 05:01
@fengxu1211 fengxu1211 changed the title support passing AKSK to the bedrock client feat: support passing AKSK to the bedrock client Dec 5, 2024
@NingLu NingLu merged commit 8385123 into aics Dec 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants