Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add some desc in chatbot settings #501

Merged
merged 2 commits into from
Jan 3, 2025
Merged

refactor: add some desc in chatbot settings #501

merged 2 commits into from
Jan 3, 2025

Conversation

530051970
Copy link
Collaborator

@530051970 530051970 commented Jan 3, 2025

Fixes #

🤖 AI-Generated PR Description (Powered by Amazon Bedrock)

Description

This pull request introduces modifications to the rag.py file in the langchain_integration module and the ChatBot.tsx file in the portal application. The changes aim to enhance the integration between the Retrieval Augmented Generation (RAG) model and the chatbot interface, providing improved conversational capabilities.

The rag.py file has been updated to optimize the retrieval and generation processes, ensuring more relevant and coherent responses from the RAG model. Additionally, error handling and input validation have been improved for increased robustness.

In the ChatBot.tsx file, the user interface has been modified to better display the responses generated by the RAG model. This includes formatting enhancements, improved layout, and better handling of long responses.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

File Stats Summary

File number involved in this PR: 2, unfold to see the details:

The file changes summary is as follows:

Files
Changes
Change Summary
source/lambda/online/common_logic/langchain_integration/tools/common_tools/rag.py 1 added, 1 removed The code change modifies the default value of top_k from Threshold.TOP_K to Threshold.TOP_K_RETRIEVALS for the retriever configuration.
source/portal/src/pages/chatbot/ChatBot.tsx 14 added, 4 removed The code changes involve modifying the layout and adding descriptions to various form fields in the ChatBot component. The grid layout for the form fields has been updated, and descriptions have been added to fields such as scenario, model name, max tokens, max rounds, endpoint, temperature, top K retrievals, and score using the description prop.

@530051970 530051970 changed the title refact: add some desc in chatbot settings refactor: add some desc in chatbot settings Jan 3, 2025
@530051970 530051970 requested a review from NingLu January 3, 2025 03:41
@NingLu NingLu merged commit 41d316d into dev Jan 3, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants