Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input component issues when pages opened by firefox #506

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

530051970
Copy link
Collaborator

@530051970 530051970 commented Jan 7, 2025

Fixes #

  1. input component issues when pages opened by firefox
  2. some params check issues
🤖 AI-Generated PR Description (Powered by Amazon Bedrock)

Description

This pull request updates the dependencies for the chatbot feature in the portal application. The package.json and package-lock.json files have been modified to include the latest version of the chatbot library. Additionally, the ChatBot.tsx file has been updated to utilize the new API introduced in the latest version of the chatbot library.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

File Stats Summary

File number involved in this PR: 3, unfold to see the details:

The file changes summary is as follows:

Files
Changes
Change Summary
source/portal/package.json 0 added, 1 removed The code changes remove the @cloudscape-design/component-toolkit dependency and update the versions of @cloudscape-design/components and axios dependencies.
source/portal/package-lock.json 13 added, 14 removed The code changes involve updating dependencies in a React project. Specifically, it removes the @cloudscape-design/component-toolkit dependency, downgrades the @cloudscape-design/components version, and updates the @cloudscape-design/global-styles and ace-builds versions.
source/portal/src/pages/chatbot/ChatBot.tsx 22 added, 11 removed The code changes include: adding event listeners for composition start/end to an input element instead of the document, fixing variable name typos for error state setters, adding input validation for max rounds and top K retrievals values between 0-100, changing the step value for score input to 0.01.
🤖 AI-Generated PR Description (Powered by Amazon Bedrock)

Description

This pull request updates the dependencies for the chatbot feature in the portal application. The package.json and package-lock.json files have been modified to include the latest versions of the required dependencies. Additionally, the ChatBot.tsx file has been updated to utilize the new dependency versions and improve the overall functionality of the chatbot feature.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

File Stats Summary

File number involved in this PR: 3, unfold to see the details:

The file changes summary is as follows:

Files
Changes
Change Summary
source/portal/package.json 0 added, 1 removed The code change removes the @cloudscape-design/component-toolkit dependency and updates the versions of @cloudscape-design/components and axios dependencies.
source/portal/src/pages/chatbot/ChatBot.tsx 23 added, 11 removed The code changes include: resetting the user message when starting a new session, adding event listeners for input composition on the input element instead of the document, validating and handling errors for max rounds and top K retrievals input fields, restricting the input range for max rounds, top K retrievals, and score, and adjusting the step value for the score input field.
source/portal/package-lock.json 13 added, 14 removed The code changes involve updating dependencies in a React project. Specifically, it removes the @cloudscape-design/component-toolkit dependency, updates @cloudscape-design/components to version 3.0.604, downgrades @cloudscape-design/global-styles to 1.0.27, and downgrades ace-builds to 1.32.9.

@530051970 530051970 requested a review from NingLu January 7, 2025 08:28
@NingLu NingLu merged commit 39d6418 into dev Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants