Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecs interface to ecs shared library in ecs-agent. #3983

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

RichaGangwar
Copy link
Contributor

Summary

Add the ECS client API interfaces to shared library under ecs-agent/api/ecs folder.

Implementation details

  1. Added a new file interface.go with relevant interfaces to ecs-agent/api/ecs.
  2. Moved the ecs api model files from ecs-agent/ecs to ecs-agent/api/ecs.

Testing

make test

New tests cover the changes: No

Description for the changelog

Add ecs interface to ecs shared library in ecs-agent.

Does this PR include breaking model changes? If so, Have you added transformation functions?

No

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@timj-hh timj-hh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the /ecs-agent/vendor as well here?

@RichaGangwar
Copy link
Contributor Author

Do we need to update the /ecs-agent/vendor as well here?
I had run go mod tidy and go mod vendor on both agents to update, but looks like there is nothing to be updated to the vendor directory.

@RichaGangwar RichaGangwar requested a review from timj-hh October 26, 2023 17:38
@danehlim danehlim merged commit c4aa37a into aws:dev Oct 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants