Move ec2 module to shared library #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj-hh
force-pushed
the
ec2_sharedlib
branch
from
b518605 to
2dfc683
Compare
timj-hh
force-pushed
the
ec2_sharedlib
branch
from
2dfc683 to
375434c
Compare
danehlim
previously approved these changes
Oct 26, 2023
RichaGangwar
previously approved these changes
Oct 27, 2023
timj-hh
force-pushed
the
ec2_sharedlib
branch
7 times, most recently
from
3ceab27 to
f4914f1
Compare
danehlim
approved these changes
Oct 27, 2023
RichaGangwar
approved these changes
Oct 30, 2023
timj-hh
force-pushed
the
ec2_sharedlib
branch
from
754600b to
8d8251b
Compare
timj-hh
force-pushed
the
ec2_sharedlib
branch
from
8d8251b to
e35ec9f
Compare
timj-hh
force-pushed
the
ec2_sharedlib
branch
from
e35ec9f to
792a882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change moves the ec2 module from the ECS agent module to the shared library, and updates references to it in the remaining codebase. ec2 module is needed for ECS frontend migration to the shared library.
Implementation details
agent/toecs-agentseelogwith sharedloggermodulemake gogenerateto update mocksgo mod tidy && go mod vendorran in bothagentandecs-agentdirectories. This will cause the generation of ec2 dependencies likeaws-sdk-goto be created in theecs-agentmodule.Testing
make test && make run-integ-testsNew tests cover the changes: no
Description for the changelog
Move ec2 module to shared library
Does this PR include breaking model changes? If so, Have you added transformation functions?
no
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.