Upgrade to latest NVIDIA NVML package #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
requested changes
Jan 8, 2025
singholt
previously approved these changes
Jan 14, 2025
singholt
approved these changes
Jan 14, 2025
mye956
reviewed
Jan 14, 2025
mye956
approved these changes
Jan 14, 2025
|
This PR fixes #4466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request upgrades the NVIDIA NVML package to the latest version in the
nvidia_gpu_manager.gofile and significantly refactors the GPU manager unit tests.Implementation details
Testing
All existing unit tests were updated and verified to pass with the new NVML package version.
New tests cover the changes: yes
Description for the changelog
Upgrade to latest NVIDIA NVML package
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.