Refactor introspection api to consume shared implementation #4483
+1,892
−1,036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the effort to bring the Agent Introspection Server to the Fargate Agent, this change refactors the agent
introspection
server to consume the shared implementation inecs-agent
.Implementation details
The http server logic for the introspection server has been moved to the shared
ecs-agent
library. The server depends on theAgentState
interface which will be implemented in the ECS and Fargate agents. TheAgentState
implementations will supply the server with the data it needs to construct responses. This change refactors the ECS agent's introspection server to consume the shared introspection server.Testing
Unit and integration tests
Existing unit and integration tests have been modified, and where applicable, additional tests have been added. Existing
unit
tests forintrospection_server
inagent/handlers/v1
were moved to anintegration
test file with the intent to:Manual tests
Outputs from the Agent introspection server were recorded from two test clusters: one using the current version of the ECS agent, and the other using a modified build with the shared introspection server implementation. E.g.,
/v1/metadata
Current implementation
Shared implementation
New tests cover the changes: yes
Description for the changelog
Enhancement - Refactor introspection api to consume shared server in ecs-agent
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.