Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolkit Action: bootstrap incl. typed return #33180

Closed
mrgrain opened this issue Jan 27, 2025 · 1 comment · Fixed by aws/aws-cdk-cli#63
Closed

Toolkit Action: bootstrap incl. typed return #33180

mrgrain opened this issue Jan 27, 2025 · 1 comment · Fixed by aws/aws-cdk-cli#63
Assignees
@iankhou
Labels
@aws-cdk/toolkit p2

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Jan 27, 2025 •
edited
Loading

Follow the pattern of #33298 but for the bootstrap action.

We are looking for:

  • a copy-paste-and-adjust implementation of the existing bootstrap action for the new Toolkit
  • corresponding new types in lib/actions/bootstrap
  • 100% test coverage for the "new" code
  • A suggestion for what this method should return (new feature)
@mrgrain mrgrain changed the title Action: bootstrap incl. typed return Toolkit Action: bootstrap incl. typed return Jan 27, 2025
@github-actions github-actions bot mentioned this issue Feb 1, 2025
Closed
This was referenced Feb 14, 2025
Closed
Merged
github-merge-queue bot pushed a commit to aws/aws-cdk-cli that referenced this issue Mar 3, 2025
@iankhou @mrgrain
feat(toolkit-lib): bootstrap action (#63)
faa2de0 
Fixes aws/aws-cdk#33180. Typed return will be
included in a follow-up PR.

Description:  

Bootstrap Action for the CDK Toolkit.

Testing:
- Unit test coverage for:
  - Bootstrap stack creation
  - No-op (no stack changes)
  - Generic bootstrap error
  - Permissions error during bootstrap
- Bootstrapped an environment in a test account using this code


---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Momo Kornher <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iankhou iankhou

Labels
@aws-cdk/toolkit p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(toolkit-lib): bootstrap action aws/aws-cdk-cli
feat(toolkit): bootstrap action aws/aws-cdk
2 participants
@mrgrain @iankhou