feat(toolkit-lib): bootstrap action #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankhou
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iankhou
changed the title
1 task
iankhou
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
reviewed
Feb 19, 2025
packages/@aws-cdk/toolkit-lib/lib/actions/bootstrap/private/helpers.ts
Outdated
Show resolved
Hide resolved
mrgrain
reviewed
Feb 19, 2025
mrgrain
reviewed
Feb 19, 2025
packages/@aws-cdk/toolkit-lib/lib/api/bootstrap/bootstrap-template.yaml
Outdated
Show resolved
Hide resolved
mrgrain
reviewed
Feb 19, 2025
mrgrain
reviewed
Feb 19, 2025
mrgrain
reviewed
Feb 19, 2025
mrgrain
reviewed
Feb 19, 2025
mrgrain
reviewed
Feb 19, 2025
mrgrain
reviewed
Feb 19, 2025
mrgrain
reviewed
Feb 19, 2025
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
mrgrain
reviewed
Feb 19, 2025
| /** | ||
| * Bootstrap Action | ||
| */ | ||
| public async bootstrap(cx: ICloudAssemblySource, options: BootstrapEnvironmentOptions = {}): Promise<void> { |
There was a problem hiding this comment.
This action has a slightly different syntax. It's an environment based action that takes in a list of environment strings.
There is an option to read environments from a provided cx (see defineEnvironments` in the current code). But I'm wondering if we should instead provide this as a helper function that can be called "outside".
There was a problem hiding this comment.
Added userEnvironmentSpecs, which, when empty, will select all environments from all stacks (like deploy).
There was a problem hiding this comment.
In the new interface, the function must be called with either environments or cx.
There was a problem hiding this comment.
Just kidding, I created a new class called BootstrapEnvironments that takes in either a cx or list of envs.
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iankhou
force-pushed
the
iankhou-toolkit-bootstrap
branch
from
d62ac6d to
5d0f33d
Compare
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iankhou
commented
Feb 20, 2025
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iankhou
requested a deployment
to
integ-approval
GitHub Actions
Waiting
mrgrain
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/aws-cdk#33180. Typed return will be included in a follow-up PR.
Description:
Bootstrap Action for the CDK Toolkit.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license