feat(bootstrap): Add ECR resource policy for emr-serverless containers #112
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydenshand
requested a deployment
to
integ-approval
GitHub Actions
Waiting
graydenshand
changed the title
graydenshand
changed the title
graydenshand
requested a deployment
to
integ-approval
GitHub Actions
Waiting
graydenshand
requested a deployment
to
integ-approval
GitHub Actions
Waiting
rix0rrr
requested changes
Mar 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 84.46% 84.73% +0.26%
==========================================
Files 205 205
Lines 35648 35648
Branches 4579 4597 +18
==========================================
+ Hits 30109 30205 +96
+ Misses 5393 5291 -102
- Partials 146 152 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
March 3, 2025 13:01
Head branch was pushed to by a user without write access
graydenshand
requested a deployment
to
integ-approval
GitHub Actions
Waiting
graydenshand
requested a deployment
to
integ-approval
GitHub Actions
Waiting
|
Thanks for the feedback, @rix0rrr -- I've incremented the template version. |
graydenshand
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
rix0rrr
approved these changes
Mar 3, 2025
graydenshand
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
|
@graydenshand You can stop updating from main now. We take care of it from here. Updating will just invalidate the tests and make everything take longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the default bootstrap template to support EMR Serverless containers.
Without this policy, containers created using the
DockerImageAssetconstruct cannot be used with EMR Serverless applications.There is precedence for this pattern to support Lambda function containers, so I don't think this should be too controversial of a change.
Relevant documentation on using custom images in EMR Serverless:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license