refactor: move util into shared library
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
commented
Mar 3, 2025
| * released and `__dirname` will refer to a different location in the `.ts` form | ||
| * as it will in the final executing form. | ||
| */ | ||
| export function rootDir(): string; |
There was a problem hiding this comment.
This stays in the cli package
mrgrain
commented
Mar 3, 2025
| @@ -1,4 +1,4 @@ | |||
| import * as fs from 'fs-extra'; | |||
| import * as fs from 'fs/promises'; | |||
There was a problem hiding this comment.
fs-extra wasn't needed at all here.
mrgrain
commented
Mar 3, 2025
mrgrain
commented
Mar 3, 2025
mrgrain
commented
Mar 3, 2025
| @@ -63,3 +62,14 @@ describe('splitBySize', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| describe('applyDefaults', () => { | |||
There was a problem hiding this comment.
this was previously in a separate file for some reason
mrgrain
commented
Mar 3, 2025
mrgrain
commented
Mar 3, 2025
packages/aws-cdk/lib/cli/root-dir.ts
Outdated
There was a problem hiding this comment.
moved from util.ts and renamed function
mrgrain
commented
Mar 3, 2025
There was a problem hiding this comment.
combined with an other test file for objects
mrgrain
force-pushed
the
mrgrain/refactor/move-util
branch
from
a03d4fa to
ae36265
Compare
rix0rrr
approved these changes
Mar 3, 2025
mrgrain
force-pushed
the
mrgrain/refactor/move-util
branch
from
ae36265 to
60d3f7d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 84.84% 84.69% -0.15%
==========================================
Files 205 207 +2
Lines 35648 35647 -1
Branches 4617 4594 -23
==========================================
- Hits 30245 30191 -54
- Misses 5245 5307 +62
+ Partials 158 149 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrgrain
force-pushed
the
mrgrain/refactor/move-util
branch
from
60d3f7d to
2e4eeb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly moving and import updates.
Renamed a couple of functions.
Added some more AI generated test cases for utils.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license