docs(cdk-lib): fix typos #33008
docs(cdk-lib): fix typos #33008
Conversation
github-actions
bot
added
p2
admired-contributor
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33008 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 232 232
Lines 14111 14111
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2431 2431
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -964,7 +964,7 @@ export abstract class BucketBase extends Resource implements IBucket { | |||
| * Function to add required permissions to the destination bucket for cross account | |||
| * replication. These permissions will be added as a resource based policy on the bucket | |||
| * @see https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication-walkthrough-2.html | |||
| * If owner of the bucket needs to be overriden, set accessControlTransition to true and provide | |||
| * If owner of the bucket needs to be overridden, set accessControlTransition to true and provide | |||
There was a problem hiding this comment.
I see other 5 occurrences of this typo in the project. Can you please adjust those as well?
There was a problem hiding this comment.
Thank you, I fix it.
aws-cdk-automation
removed
the
pr/needs-community-review
|
@andyu17 It seems like the linter is complaining 
|
aws-cdk-automation
dismissed
their stale review
Dismissing outdated PRLinter review.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #.
None
Fixed typos in code comments.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license