Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Replaced /my-bucket/ with amzn-s3-demo-bucket #9272

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ashovlin
Copy link
Member

@ashovlin ashovlin commented Feb 3, 2025

Issue #, if available: V2 port of #9223

Description of changes: This is applying the V1 example changes in #9223 to V2. I had to cherry-pick manually because some of the CloudTrail commands don't exist in V2.

Note that there is only one commit here vs. 3 on the original:

  1. 6699ef9 - was cherry-picked
  2. a3a82e3 - was a merge commit
  3. 90ad642 - didn't have changes when cherry-picking, after addressing conflicts when cherry-picking the first commit.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ashovlin ashovlin merged commit ab754f0 into aws:v2 Feb 4, 2025
41 of 45 checks passed
@ashovlin ashovlin deleted the shovlia/v2-my-bucket branch February 4, 2025 15:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d413154) to head (4dd44bf).
Report is 17 commits behind head on v2.

Additional details and impacted files
@@    Coverage Diff     @@
##   v2   #9272   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants