Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add protocols trait support #9291

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Feb 11, 2025

This is a port of boto/botocore#3376 to our vendored botocore.

Description of changes:

  • Add support for protocols trait on service models.
  • Selects the highest priority supported protocol.
  • Falls back to legacy protocol trait if service model does not define protocols trait.

Description of tests:

  • Ran and passed all tests (unit, functional, integration, etc.)
  • No further CLI-specific tests are needed because the CLI is protocol-agnostic; protocol behavior is fully contained within botocore.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous marked this pull request as ready for review February 11, 2025 17:51
@aemous aemous requested review from aws-sdk-python-automation and a team February 11, 2025 18:15
@aemous aemous merged commit 1397afb into aws:v2 Feb 12, 2025
41 of 45 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d413154) to head (9d983ee).
Report is 43 commits behind head on v2.

Additional details and impacted files
@@    Coverage Diff     @@
##   v2   #9291   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nateprewitt added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants