Update Lambda blueprints for .NET 8 #1673

normj · 2024-02-17T00:57:11Z

Description of changes:
In preparation for .NET 8 Lambda support update the blueprints. The update has the following changes.

Update all TargetFramework tags to net8.0.
Update Lambda runtime targets to dotnet8
Update the default memory size to 512 to match what is done in other languages like Java.
Updated referenced in README files for target frameworks and Amazon Linux versions.
Update Simple DynamoDB blueprint to handle the recent major version bump of the event package. That major version bump removed the dependency from the event package to the AWSSDK.DynamoDBv2 package.
Update the serverless Native AOT blueprint to use Amazon.Lambda.Annotations. This takes care of generating the required main method.
Update all of the AWS package references in the blueprints project files. This includes Lambda, SDK and PowerTools packages. The versions are updated using the following msbuild command from our build.proj file

dotnet msbuild .\buildtools\build.proj /t:run-blueprint-packager /p:UpdateBlueprintPackageVersions=true

Native AOT projects will target the dotnet8 runtime instead of provided.al2023. This is done because provided.al2023 does not have the required libicu system library and avoid having to include it with the deployment bundle. You will see in the project files the removal of the logic to include libicu. This also remove the need to name the assembly as bootstrap.

Testing

Run the msbuild target /t:test-blueprints-dotnew that confirms all blueprints can be instantiated and compiled
Manually deployments of the Native AOT and DynamoDB blueprints that had significant changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

normj · 2024-02-17T01:10:56Z

...lueprintDefinitions/vs2022/NativeAOTServerless/template/src/BlueprintBaseName.1/Functions.cs


 namespace BlueprintBaseName._1;

+/// <summary>


This is the serverless Native AOT blueprint. It used to have its own Main method and logic for switching to the correct method based on an environment variable. Amazon.Lambda.Annotations can now do all of this for us so I removed all of the logic and relied on Lambda Annotations.

I the Lambda methods, JsonSerializerContext and the .NET records in the same file to make it really easy for users that start with this template quickly delete what they don't need once they understand how this works.

normj · 2024-02-17T01:14:01Z

...vs2022/SimpleDynamoDBFunction-FSharp/template/test/BlueprintBaseName.1.Tests/FunctionTest.fs

@@ -1,12 +1,9 @@
 namespace BlueprintBaseName._1.Tests


This file has significant changes to deal with change to move to new major version of Amazon.Lambda.DynamoDBEvents which removed the dependency on the SDK.

normj · 2024-02-17T01:14:19Z

...itions/vs2022/SimpleDynamoDBFunction/template/test/BlueprintBaseName.1.Tests/FunctionTest.cs

@@ -1,11 +1,9 @@
 using Xunit;


This file has significant changes to deal with change to move to new major version of Amazon.Lambda.DynamoDBEvents which removed the dependency on the SDK.

philasmar · 2024-02-19T20:26:56Z

...ints/BlueprintDefinitions/vs2022/EmptyFunction-Image/template/.template.config/template.json

@@ -5,7 +5,7 @@
    "Lambda",
    "Function"
  ],
-  "name": "Lambda Empty Function (.NET 7 Container Image)",


You removed "NET"

philasmar · 2024-02-19T20:50:11Z

...lueprintDefinitions/vs2022/NativeAOTServerless/template/src/BlueprintBaseName.1/Functions.cs


 namespace BlueprintBaseName._1;

+/// <summary>
+/// This class is used to register the input event and return type for the FunctionHandler method with the System.Text.Json source generator.


nit: use doc reference for all the types you mentioned in docs

I'm gonna skip doing this now. We haven't made any effort to doc references in code elements in the other blueprints and if we want to do that we should do that as a separate effort.

I'm a little hesitant to use them here anyways because these comments are meant to be easily readable while reading the code in this file. Not via a doc site or intellisense. Think of these docs as more of a developer guide type content as you are reading the source. I expect users to replace all of this content with the actual content useful to their problem. Having to read the content with a bunch of xml tags useful for a doc site or intellisense makes it harder to read.

philasmar · 2024-02-19T20:51:15Z

...lueprintDefinitions/vs2022/NativeAOTServerless/template/src/BlueprintBaseName.1/Functions.cs

+
+

nit: remove whitespace

philasmar · 2024-02-19T20:51:55Z

...lueprintDefinitions/vs2022/NativeAOTServerless/template/src/BlueprintBaseName.1/Functions.cs

+    /// <param name="context"></param>
+    /// <returns></returns>


nit: add docs to empty attributes

philasmar · 2024-02-19T20:53:02Z

...lueprintDefinitions/vs2022/NativeAOTServerless/template/src/BlueprintBaseName.1/Functions.cs

-    // SDK for .NET does not support trimming. This will result in a larger executable size, and still does not 
-    // guarantee runtime trimming errors won't be hit. 
+    /// This method demonstrates methods being exposed as Lambda functions using Amazon.Lambda.Annotations without API Gateway attributes.
+    /// The event source for the Lambda function can be configured in the serverless.template. The method can also Lambda function can     


the sentence is weirdly formed "The method can also Lambda function can be invoked manually using the AWS SDKs.

philasmar · 2024-02-19T21:07:39Z

...s/BlueprintDefinitions/vs2022/NativeAOTServerless/template/src/BlueprintBaseName.1/Readme.md

+For Native AOT Lambda functions the project must be deployed as an executable and bootstrap the Lambda runtime client. Lambda Annotations
+will automatically generate the `Main` by using the `GenerateMain` property of `LambdaGlobalProperties` attribute to true. The generated
+`Main` method uses the environment variable `ANNOTATIONS_HANDLER` to switch to the correct function handler for the executable. Lambda
+Annotations will automatically set the `ANNOTATIONS_HANDLER` environment variable when synchronize the CloudFormation template. If deploying


nit: typo in "synchronize"

...efinitions/vs2022/EmptyServerless-Image/template/src/BlueprintBaseName.1/serverless.template

...printDefinitions/vs2022/EmptyServerless/template/src/BlueprintBaseName.1/serverless.template

...ons/vs2022/NativeAOTFunction/template/src/BlueprintBaseName.1/aws-lambda-tools-defaults.json

Update Lambda blueprints for .NET 8

f19623f

normj force-pushed the normj/dotnet8-blueprints branch from 243397b to f19623f Compare February 17, 2024 01:01

normj commented Feb 17, 2024

View reviewed changes

philasmar reviewed Feb 19, 2024

View reviewed changes

ashovlin reviewed Feb 19, 2024

View reviewed changes

...efinitions/vs2022/EmptyServerless-Image/template/src/BlueprintBaseName.1/serverless.template Show resolved Hide resolved

ashovlin reviewed Feb 19, 2024

View reviewed changes

...printDefinitions/vs2022/EmptyServerless/template/src/BlueprintBaseName.1/serverless.template Show resolved Hide resolved

ashovlin reviewed Feb 19, 2024

View reviewed changes

...ons/vs2022/NativeAOTFunction/template/src/BlueprintBaseName.1/aws-lambda-tools-defaults.json Show resolved Hide resolved

normj added 2 commits February 19, 2024 14:58

Addressed Phil's PR comments.

7d90e6a

Addressed Alex's PR comments

4aefdda

ashovlin approved these changes Feb 20, 2024

View reviewed changes

philasmar approved these changes Feb 20, 2024

View reviewed changes

normj merged commit a4007ba into net8-staging Feb 20, 2024
4 checks passed

normj deleted the normj/dotnet8-blueprints branch February 20, 2024 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Lambda blueprints for .NET 8 #1673

Update Lambda blueprints for .NET 8 #1673

normj commented Feb 17, 2024 •

edited

Loading

normj Feb 17, 2024 •

edited

Loading

normj Feb 17, 2024

normj Feb 17, 2024

philasmar Feb 19, 2024

normj Feb 19, 2024

philasmar Feb 19, 2024

normj Feb 19, 2024

philasmar Feb 19, 2024

normj Feb 19, 2024

philasmar Feb 19, 2024

normj Feb 19, 2024

philasmar Feb 19, 2024

normj Feb 19, 2024

philasmar Feb 19, 2024

normj Feb 19, 2024

Update Lambda blueprints for .NET 8 #1673

Update Lambda blueprints for .NET 8 #1673

Conversation

normj commented Feb 17, 2024 • edited Loading

Testing

normj Feb 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

normj commented Feb 17, 2024 •

edited

Loading

normj Feb 17, 2024 •

edited

Loading