Skip to content

Commit

Permalink
fix(build): tuner: prefer ncclInvalidArgument
Browse files Browse the repository at this point in the history
ncclInvalidArgument is present both in neuron and nvidia whereas
ncclInvalidUsage is only present in neuron headers. Callsite just wraps
the value in ncclcheck and the meaning isn't meaningfully changed, so
prefer the portable one.
  • Loading branch information
Nicholas Sielicki committed Mar 11, 2024
1 parent 9d8a467 commit af2f4ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/tuner/nccl_ofi_tuner.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ncclResult_t nccl_ofi_tuner_init(size_t nRanks, size_t nNodes, ncclDebugLogger_t
*/
if (getenv("NCCL_ALGO") || getenv("NCCL_PROTO")) {
NCCL_OFI_WARN("The tuner plugin can not be loaded when explicitly choosing an algorithm or protocol with NCCL_ALGO/NCCL_PROTO");
return ncclInvalidUsage;
return ncclInvalidArgument;
}

struct nccl_ofi_tuner_model_params params = {
Expand Down

0 comments on commit af2f4ca

Please sign in to comment.