quality-of-life fixes: clang-format, clang-static-analyzer, pre-commit

.ci/aws/aws_ofi_nccl_pr_ci.yaml

@@ -1,11 +1,12 @@
+---
 general:
-  timeout: 180
-  enable_live_log: true
+    timeout: 180
+    enable_live_log: true
 cluster:
-  cluster_type: manual_cluster
+    cluster_type: manual_cluster
 testing:
-  test_target: aws-ofi-nccl
-  test_type: pr
-  aws_ofi_nccl_build_type: debug
-  test_list:
-    - test_nccl_test
+    test_target: aws-ofi-nccl
+    test_type: pr
+    aws_ofi_nccl_build_type: debug
+    test_list:
+        - test_nccl_test

.clang-format

@@ -0,0 +1,61 @@
+---
+BasedOnStyle: Google
+InsertNewlineAtEOF: true
+LineEnding: LF
+ColumnLimit: 100
+TabWidth: 8
+IndentWidth: 8
+BracedInitializerIndentWidth: 8
+ContinuationIndentWidth: 8
+SpacesBeforeTrailingComments: 2
+ReflowComments: true
+IndentCaseLabels: false
+
+BreakBeforeBraces: Linux
+UseTab: ForContinuationAndIndentation
+MaxEmptyLinesToKeep: 2
+AlignOperands: Align
+AllowAllArgumentsOnNextLine: false
+BinPackArguments: false
+BinPackParameters: false
+AlignConsecutiveDeclarations: false
+AlignConsecutiveAssignments: false
+
+AlignTrailingComments:
+    Kind: Always
+    OverEmptyLines: 0
+AlignConsecutiveShortCaseStatements:
+    Enabled: true
+    AcrossEmptyLines: true
+    AcrossComments: true
+    AlignCaseColons: false
+AlignConsecutiveMacros:
+    Enabled: true
+    AcrossEmptyLines: true
+    AcrossComments: true
+
+AlignConsecutiveBitFields:
+    Enabled: true
+    AcrossEmptyLines: true
+    AcrossComments: true
+
+PointerAlignment: Right
+ReferenceAlignment: Right
+AllowShortFunctionsOnASingleLine: None
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+RemoveParentheses: MultipleParentheses
+InsertBraces: true
+
+SortIncludes: CaseSensitive
+IncludeBlocks: Regroup
+IncludeCategories:
+  # External dependencies at the top.
+    - Regex: ^([<].*[.]h[>])$
+      Priority: -50
+      SortPriority: -50
+
+  # local headers below them.
+    - Regex: ^(["].*[.]h["])$
+      Priority: -10
+      SortPriority: -10

.clang-tidy

@@ -0,0 +1,53 @@
+---
+Checks:
+    - -*
+    - cert-dcl16-c
+    - optin-mpi-mpi-checker-c
+    - optin.core.EnumCastOutOfRange
+    - optin-performance-padding
+    - clang-analyzer-core*
+    - clang-analyzer-nullability*
+    - clang-analyzer-optin.core.EnumCastOutOfRange
+    - clang-analyzer-optin.performance.Padding
+    - clang-analyzer-security*
+    - clang-analyzer-unix*
+    - -clang-analyzer-security.insecureAPI*
+    - bugprone-*
+    - -bugprone-easily-swappable-parameters
+    - -bugprone-assignment-in-if-condition
+    - -bugprone-multi-level-implicit-pointer-conversion
+    - misc-const-correctness
+    - misc-static-assert
+    - misc-misplaced-const
+    - misc-redundant-expression
+    - misc-header-include-cycle
+    - misc-definitions-in-headers
+    #- misc-include-cleaner
+    - readability-avoid-const-params-in-decls
+    - readability-avoid-return-with-void-value
+    - readability-avoid-unconditional-preprocessor-if
+    - readability-braces-around-statements
+    - readability-const-return-type
+    - readability-const-return-type
+    - readability-duplicate-include
+    - readability-implicit-bool-conversion
+    - readability-inconsistent-declaration-parameter-name
+    - readability-misleading-indentation
+    - readability-misplaced-array-index
+    - readability-named-parameter
+    - readability-non-const-parameter
+    - readability-redundant-control-flow
+    - readability-redundant-declaration
+    - readability-redundant-inline-specifier
+    - readability-simplify-boolean-expr
+    - readability-simplify-subscript-expr
+    - readability-string-compare
+    - readability-suspicious-call-argument
+    - readability-uppercase-literal-suffix
+WarningsAsErrors: true
+FormatStyle: file
+CheckOptions:
+    - key: readability-uppercase-literal-suffix.NewSuffixes
+      value: L;LL;LU;LLU
+    - key: misc-include-cleaner.IgnoreHeaders
+      value: include/nccl-headers/.*

.ecrc

@@ -0,0 +1,19 @@
+{
+  "Version": "2.7.2",
+  "Verbose": false,
+  "Debug": false,
+  "IgnoreDefaults": false,
+  "SpacesAftertabs": true,
+  "NoColor": false,
+  "Exclude": [],
+  "AllowedContentTypes": [],
+  "PassedFiles": [],
+  "Disable": {
+    "EndOfLine": false,
+    "Indentation": false,
+    "InsertFinalNewline": false,
+    "TrimTrailingWhitespace": false,
+    "IndentSize": false,
+    "MaxLineLength": false
+  }
+}

.editorconfig

@@ -0,0 +1,15 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+insert_final_newline = true
+
+[*.md]
+indent_style = space
+indent_size = 1
+
+[*.[ch]]
+indent_style = tab
+indent_size = 8
+trim_trailing_whitespace = true

.git-blame-ignore-revs

@@ -0,0 +1,11 @@
+# build: take iwyu fixes
+0e2d51dbd070df17cc5c3d1966a7c1f9e81b3a99
+
+# fix: take mdformat fixes
+f9cbf3b8914db0a8744456441cb57443388b7dfe
+
+# nit: apply eof/trailing whitespace fixes
+a50ebf1b5e1e12d7788a1a22a53f0d7e8c77b946
+
+# nit: apply yamlfmt fixes to tree
+3d8a9d1ffed34da06581ec2bd971f03d41dcb6ac

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,5 +2,4 @@
 
 *Description of changes:*
 
-
 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

.github/codechecker.yaml

@@ -0,0 +1,6 @@
+---
+analyzer:
+    - --disable=clang-diagnostic-unused-parameter
+    - --ignore=.github/codechecker_skips.txt
+    - --analyzer-config=clangsa:unroll-loops=true
+    - --report-hash=context-free-v2

.github/codechecker_skips.txt

@@ -0,0 +1,3 @@
+-/tests/functional/*
+-/tests/unit/*
+-/include/nccl-headers/*/*