Fix: sam sync defintion validator handling file opened event #7271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
For definition files (e.g. APIGW, SFN), a validation step is done for each FS event caught by watchdog. The validation step compares the file changes and determines if it's a valid change to sync. However, the validation step checks the file as of current but not the time when the event happened. As a result, we saw "changes" occurred and validated for a "File Opened Event", which is then ignored, and thus did not result in any sync.
How does it address the issue?
Explicitly skip File Opened Event in the validation step.
What side effects does this change have?
Definition files are not validated for a File Opened Event. However, this should be fine since we do not create sync flow from File Opened Event anyway.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.