fix: handle generic error #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucashuy
approved these changes
Oct 22, 2024
Comment on lines
368
to
367
| except (Exception): | ||
| LOG.warning("No current session found, using default AWS::AccountId") |
There was a problem hiding this comment.
Not blocking anything, but I wonder if its worth logging what exception we voided as a debug log. Since this method is a "best effort" attempt at getting an account ID, its not critical, but could help with visibility into what happened.
hawflau
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#7585 there was an instance of boto3 returning an unhandled exception
Why is this change necessary?
How does it address the issue?
This part of local is not critical to its execution so we should be fine to just blanket catch all exceptions here.
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.