Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD_OPENSSL comment #3133

Merged
merged 1 commit into from
Oct 2, 2024
Merged

BUILD_OPENSSL comment #3133

merged 1 commit into from
Oct 2, 2024
+2 −0

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented Oct 1, 2024 •
edited
Loading

Issue #, if available:
#2989 (comment)

Would be helpful to also document the BUILD_OPENSSL cmake option, though

Adding this PR for clarification

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmklix jmklix merged commit 333c92c into main Oct 2, 2024
4 checks passed
@jmklix jmklix deleted the BUILD_OPENSSL branch October 2, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbiscigl sbiscigl sbiscigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmklix @sbiscigl