Create interfaces for smithy interceptors #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
force-pushed
the
create-smithy-interceptors
branch
2 times, most recently
from
27d8f3b to
5699728
Compare
sbera87
reviewed
Oct 2, 2024
src/aws-cpp-sdk-core/include/smithy/interceptor/InterceptorContext.h
Outdated
Show resolved
Hide resolved
sbera87
reviewed
Oct 2, 2024
tests/aws-cpp-sdk-core-tests/smithy/interceptor/InterceptorTest.cpp
Outdated
Show resolved
Hide resolved
sbera87
reviewed
Oct 2, 2024
sbera87
approved these changes
Oct 3, 2024
sbiscigl
force-pushed
the
create-smithy-interceptors
branch
from
5699728 to
85ab868
Compare
sbiscigl
force-pushed
the
create-smithy-interceptors
branch
from
85ab868 to
cf68d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Creates a paritial implementation of smithy interfaces for use in the SDK. The Rust SDK uses interceptors to compose discrete parts of their SDK. For example they apply checksums as part of one of their interceptors and we plan on moving our logic to one as well.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.