Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aws chunked encoding for a empty stream #3261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbiscigl
Copy link
Contributor

Issue #, if available:

Incorrect chunked encoding with 0-length underlying stream #3259

Description of changes:

Fixes a issue where if a empty stream was provided to a s3 operation it would write a empty chunk followed by another empty chunk before the trailer resulting in a aws-chunked stream that looked like

0\r\n\r\n0\r\nx-amz-checksum-crc32:AAAAAA==\r\n\r\n

where it should look like

0\r\nx-amz-checksum-crc32:AAAAAA==\r\n\r\n

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review January 20, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants