Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where null values are not handled properly when S3EventNo… #5770

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jan 3, 2025

…tification.fromJson is invoked

Motivation and Context

Fixed a bug where null values are not handled properly when S3EventNotification#fromJson is invoked, throwing IllegalArgumentException. Fix #5730

Modifications

Check JsonNode to see if it's null JsonNode

Testing

Added tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner January 3, 2025 20:54
@zoewangg zoewangg enabled auto-merge January 3, 2025 21:37
@zoewangg zoewangg added this pull request to the merge queue Jan 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2025
@zoewangg zoewangg added this pull request to the merge queue Jan 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2025
Copy link

sonarqubecloud bot commented Jan 4, 2025

@zoewangg zoewangg enabled auto-merge January 4, 2025 01:15
@zoewangg zoewangg added this pull request to the merge queue Jan 4, 2025
Merged via the queue into master with commit 5043265 Jan 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3EventNotification cannot take an unversioned S3EventNotification fromJson() -> toJson() -> fromJson()
2 participants