Do not sign Transfer-Encoding Header if present on the request #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidh44
reviewed
Feb 20, 2025
| @@ -68,7 +68,7 @@ public abstract class AbstractAws4Signer<T extends Aws4SignerParams, U extends A | |||
| private static final FifoCache<SignerKey> SIGNER_CACHE = | |||
| new FifoCache<>(SIGNER_CACHE_MAX_SIZE); | |||
| private static final List<String> LIST_OF_HEADERS_TO_IGNORE_IN_LOWER_CASE = | |||
| Arrays.asList("connection", "x-amzn-trace-id", "user-agent", "expect"); | |||
| Arrays.asList("connection", "x-amzn-trace-id", "user-agent", "expect", "transfer-encoding"); | |||
There was a problem hiding this comment.
We have the same list in HeaderTransformsHelper used by AwsS3V4ChunkSigner, do we need to add TE there also?
There was a problem hiding this comment.
Nope , it is not required here because SDK add only one Header(singletonMap) via this function , that is checksum header and its always "x-amz-checksum-XYZ"
There was a problem hiding this comment.
I can add it just to make it consistent , I think its better to add this just to be consistent and avoid further confusion , will add test directly on HeaderTransformsHelper
joviegas
force-pushed
the
joviegas/remove-transfer-encoding-from-signed
branch
from
982a946 to
ef305db
Compare
davidh44
approved these changes
Feb 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, AWS SDKs sign the Transfer-Encoding chunked header during SigV4 authentication, causing signature validation failures in specific scenarios.
The issue occurs because Transfer-Encoding is a hop-by-hop header that intermediate proxies can modify.
This change proposes to stop signing the Transfer-Encoding header in SigV4(a).
Note : for Sigv4a signers using CRT it is done in crt side with awslabs/aws-c-auth#261
Modifications
LIST_OF_HEADERS_TO_IGNORE_IN_LOWER_CASEwhich already skips some of predefined headersTesting
Transfer-EncodingScreenshots (if appropriate)
Types of changes
License