Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda extension example script instructions #21

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Conversation

ecraw-amzn
Copy link
Contributor

Issue #, if available:

Description of changes:
Instructions for using the example script secrets-manager-agent-extension.sh to install the agent as a Lambda extension.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

simonmarty
simonmarty previously approved these changes Jul 18, 2024
@simonmarty simonmarty enabled auto-merge (squash) July 18, 2024 20:27
@simonmarty simonmarty requested a review from a team as a code owner July 18, 2024 20:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.03%. Comparing base (994fe63) to head (5725924).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   69.03%   69.03%           
=======================================
  Files          13       13           
  Lines        2842     2842           
  Branches       10       10           
=======================================
  Hits         1962     1962           
  Misses        880      880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joebaro joebaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EKS/ECS and Docker section titles are also incorrect. The EKS/ECS section should actually be called "[ Amazon EC2 ]" and the Docker section should be "[ Amazon EKS, Amazon ECS, and Docker ]" or "[ Running as a Container Side Car ]".

@simonmarty simonmarty merged commit 61ee44e into aws:main Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants