Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to agent installation #24

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

StevenEmelander
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:

  • Updated both the install script and the systemd service to use the executable name that is built (aws_secretsmanager_agent) instead of the previous aws-secrets-manager-agent.
  • Due to install script running as root, files in bin directory are not owned by the AGENTUSER. This is necessary for systemd run processes. Added additional chown to recursively set the owner to AGENTUSER within AGENTDIR.
  • Added minor change to not fail if the AGENTUSER already exists.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Updated both the install script and the systemd service to use the executable name that is built (aws_secretsmanager_agent) instead of the previous aws-secrets-manager-agent.
* Due to install script running as root, files in bin directory are not owned by the agentuser.  This is necessary for systemd run processes and so I added an additional chown to recursively set the owner to AWSAGENT within AGENTDIR.
@StevenEmelander StevenEmelander requested a review from a team as a code owner July 31, 2024 21:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (9944b7a) to head (6a5d885).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   68.96%   68.89%   -0.07%     
==========================================
  Files          14       14              
  Lines        2887     2887              
  Branches       10       10              
==========================================
- Hits         1991     1989       -2     
- Misses        896      898       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonmarty simonmarty enabled auto-merge (squash) August 1, 2024 18:05
@simonmarty simonmarty merged commit 11c92f2 into aws:main Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants