disableRollback added to cloudFormationExecuteChangeSet

[bekahmark12]

Description

Motivation

Related Issue(s), If Filed

Testing

Checklist

• I have read the README document
• I have read the CONTRIBUTING document
• My code follows the code style of this project
• I have added tests to cover my changes
• A short description of the change has been added to the changelog using the script npm run newChange

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[awschristou]

Thank you for the contribution!

The CI checks are failing with

src/tasks/CloudFormationExecuteChangeSet/TaskOperations.ts(57,23): error TS2769: No overload matches this call.
  Overload 1 of 2, '(params: ExecuteChangeSetInput, callback?: ((err: AWSError, data: ExecuteChangeSetOutput) => void) | undefined): Request<...>', gave the following error.
    Argument of type '{ ChangeSetName: string; StackName: string; DisableRollback: boolean; }' is not assignable to parameter of type 'ExecuteChangeSetInput'.
      Object literal may only specify known properties, and 'DisableRollback' does not exist in type 'ExecuteChangeSetInput'.
  Overload 2 of 2, '(callback?: ((err: AWSError, data: ExecuteChangeSetOutput) => void) | undefined): Request<ExecuteChangeSetOutput, AWSError>', gave the following error.
    Argument of type '{ ChangeSetName: string; StackName: string; DisableRollback: boolean; }' is not assignable to parameter of type '(err: AWSError, data: ExecuteChangeSetOutput) => void'.
      Object literal may only specify known properties, and 'ChangeSetName' does not exist in type '(err: AWSError, data: ExecuteChangeSetOutput) => void'.
src/tasks/CloudFormationExecuteChangeSet/TaskOperations.ts(106,25): error TS2339: Property 'DisableRollback' does not exist on type 'DescribeChangeSetInput'.

It looks like we're using Aws JS SDK 2.916.0, but DisableRollback was added in 2.956.0. @JadenSimon what would be required in order to safely bump the SDK version?

[JadenSimon]

Hey @bekahmark12 looks like our package-lock.json file was created using npm 7.x.x, what version are you using? I'd try updating npm and running npm i --package-lock-only to rebuild the file. If that doesn't work I'll make a PR to bump the SDK version.

[bekahmark12]

Okay I was indeed on npm v6, I updated to v7 and ran the npm i --package-lock-only command!

[JadenSimon]

Okay great! Now try npm i [email protected] to fix the types.

[bekahmark12]

Done!

[JadenSimon]

@bekahmark12
I'm still seeing the error so maybe a later version is needed. Looking at this history, 2.979.0 should work.

[bekahmark12]

Okay I updated the sdk to 2.979.0.

[JadenSimon]

I'm still seeing issues related to package.json for some reason. I'll make a separate PR to update dependencies to debug further.

[bekahmark12]

Great thank you so much! :)

[JadenSimon]

@bekahmark12

You should be able to drop your changes to package.json and package-lock.json and rebase/pull from mainline.