Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Azure DevOps service connection instructions in README.md #579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rchildress87
Copy link

@rchildress87 rchildress87 commented Nov 13, 2024

Description

Replaced some inaccurate instructions, replaced all references of service endpoint with service connection, added more verbosity to the service connection parameters section to make it more clear which parameters need to be filled out.

Motivation

I tried to follow the instructions in order to create a new service connection for OIDC and found the instructions difficult to understand. In some situations, they were inaccurate or the terminology was incorrect.

Related Issue(s), If Filed

N/A

Testing

N/A

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the changelog using the script npm run newChange

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Replaced some inaccurate instructions, replaced all references of service endpoint with service connection, added more verbosity to the service connection parameters section to make it more clear which parameters need to be filled out.
@rchildress87 rchildress87 requested a review from a team as a code owner November 13, 2024 21:44
@hayemaxi
Copy link
Contributor

hayemaxi commented Jan 10, 2025

Thanks for this contribution! We appreciate the effort to disambiguate the docs. The changes look good to me- however- they seem to imply that setup with Microsoft Entra ID is required. I have found that I can use OIDC without this step. (example article https://aws.amazon.com/blogs/modernizing-with-aws/how-to-federate-into-aws-from-azure-devops-using-openid-connect/)

What does this step achieve? AFAIK this only entertains accessing azure services with OIDC from the pipeline (which are usually unnecessary for AWS based tasks), but I am not confident about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants