Segment Emitter, remove unsafe Buffer method #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Issue
the Segment_emitter used the deprecated
New Buffer(data)
constructor which caused warnings on newer Node runtimes, and is noise in CloudWatch Logs.One buffer is used, and this has been replaced by the newer
Buffer.from(data)
construct.This solution will not work for node version prior to 6: it's a simple replacement rather than a more complicated backwards compatible solution Detailed here.
Given that AWS only supports 8.10 or 10.x, I submit this anyway, and you can take a decision is compatibility is of concern.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.