Development netstandard2.0 #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Long [email protected] * convert common, c#, model, and vb to .net standard * create .net standard project to consume vsworkspace * refactor shared classes from build project to common * add workspace helper class to create ProjectBuildResult from solution * move file build handler to common project for use in language analyzers * refactor analyzer code into new net standard project SIM: https://i.amazon.com/P87028632 cr: https://code.amazon.com/reviews/CR-91702675
Move workspace tests to separate test project because of possible incompatibilities with the Microsoft.Build nuget package version used in other test project
Refactor shared pre port compilation logic into ProjectBuildHelper and update tests. Also add some extra test lines for more code coverage.
Also do some refactoring to allow test code to be reused
Other projects owned by ME depend on this class and changes will mess up downstream consumers
* remove commented out project reference * undo removal of cast * remove debug assertion * replace '\' with Path.DirectorySeparatorChar
…cts to merge. Made functions public. Added BrazilConfig. cr: https://code.amazon.com/reviews/CR-96783467
Refactor the msbuild path location function to the MSBuildDetector class. After consuming this change you will need to first find the path and then pass into the AnalyzerConfiguration constructor
pranav-firake
requested review from
marknfawaz and
kanikaul-amazon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Description
Currently codelyzer is in .net core and for better compatibility with wider range of projects, this PR has changes to convert it into .NET standard 2.0.
Supplemental testing
Tested manually for sample test projects
Added unit tests for the change
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.