Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixture addition from PR #4200 #4364

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Fix fixture addition from PR #4200 #4364

merged 10 commits into from
Oct 22, 2024

Conversation

arjkesh
Copy link
Contributor

@arjkesh arjkesh commented Oct 22, 2024

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Fix fixture from PR #4200 - ensure that test gets skipped as expected for TF 2.16

Tests run

Run TF training SM tests (6db04cb)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dlc_developer_config.toml:
{   'build': {   'build_frameworks': ['tensorflow'],
                 'build_inference': False,
                 'build_training': True},
    'buildspec_override': {   'dlc-pr-tensorflow-2-training': 'tensorflow/training/buildspec-2-16-sm.yml'},
    'dev': {   'deep_canary_mode': False,
               'graviton_mode': False,
               'neuronx_mode': False},
    'test': {   'ec2_tests': False,
                'ecs_tests': False,
                'eks_tests': False,
                'sagemaker_local_tests': False,
                'sagemaker_remote_tests': True,
                'sanity_tests': False}}
@arjkesh arjkesh requested a review from a team as a code owner October 22, 2024 01:54
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added sagemaker_tests Size:S Determines the size of the PR test Reflects file change in test folder labels Oct 22, 2024
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added build Reflects file change in build folder tensorflow Reflects file change in tensorflow folder labels Oct 22, 2024
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the Size:XS Determines the size of the PR label Oct 22, 2024
@arjkesh arjkesh enabled auto-merge (squash) October 22, 2024 09:56
Copy link
Contributor

@Yadan-Wei Yadan-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to test this in PR now by removing @pytest.mark.skipif(is_pr_context(), reason=SKIP_PR_REASON)?

@arjkesh arjkesh merged commit 5060f12 into aws:master Oct 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Reflects file change in build folder sagemaker_tests Size:S Determines the size of the PR Size:XS Determines the size of the PR tensorflow Reflects file change in tensorflow folder test Reflects file change in test folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants