-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fixture addition from PR #4200 #4364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlc_developer_config.toml: { 'build': { 'build_frameworks': ['tensorflow'], 'build_inference': False, 'build_training': True}, 'buildspec_override': { 'dlc-pr-tensorflow-2-training': 'tensorflow/training/buildspec-2-16-sm.yml'}, 'dev': { 'deep_canary_mode': False, 'graviton_mode': False, 'neuronx_mode': False}, 'test': { 'ec2_tests': False, 'ecs_tests': False, 'eks_tests': False, 'sagemaker_local_tests': False, 'sagemaker_remote_tests': True, 'sanity_tests': False}}
dlc_developer_config.toml: ('Restore to ' 'https://raw.githubusercontent.com/aws/deep-learning-containers/master/dlc_developer_config.toml')
dlc_developer_config.toml: ('Restore to ' 'https://raw.githubusercontent.com/aws/deep-learning-containers/master/dlc_developer_config.toml')
Yadan-Wei
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to test this in PR now by removing @pytest.mark.skipif(is_pr_context(), reason=SKIP_PR_REASON)?
Yadan-Wei
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Reflects file change in build folder
sagemaker_tests
Size:S
Determines the size of the PR
Size:XS
Determines the size of the PR
tensorflow
Reflects file change in tensorflow folder
test
Reflects file change in test folder
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue #, if available:
Note:
If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.
All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.
Description
Fix fixture from PR #4200 - ensure that test gets skipped as expected for TF 2.16
Tests run
Run TF training SM tests (6db04cb)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.