Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs page for updating vSphere creds #9365

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

csplinter
Copy link
Member

Issue #, if available:
This is a follow-up to this PR #9189

Description of changes:

  1. Make Update vSphere credentials its own separate page
  2. Recommend using the script
  3. Provide only one set of manual steps instead of two

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2025
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (383908d) to head (c8b6460).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9365      +/-   ##
==========================================
- Coverage   69.45%   69.45%   -0.01%     
==========================================
  Files         672      672              
  Lines       49357    49357              
==========================================
- Hits        34283    34280       -3     
- Misses      13288    13290       +2     
- Partials     1786     1787       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csplinter csplinter merged commit d6c4914 into aws:main Mar 3, 2025
8 checks passed
@csplinter csplinter deleted the docs-vsphere-creds-update branch March 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants