feat: configure nodes to use resource name in dns #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default "IP name" hostname type is called out in the documentation as the legacy type, and the docs recommend using the resource name hostname type. This also makes operations easier because you can more easily determine the instance ID from the nodes list.
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
AFAIK, we have to be really careful with this change because I believe it affects interactions with CCM. I recall us hitting an issue with something like this when instance-id based naming was first introduced. |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
|
I'm unfortunately not going to be a great collaborator on this. I don't have much knowledge of k8s internals (no idea what CCM is), but this change would make my job a lot easier when trying to build tooling around k8s security detections and alerts, and include extra context for those alerts based on information available in AWS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6097
Description
The default "IP name" hostname type is called out in the documentation as the legacy type, and the docs recommend using the resource name hostname type. This also makes operations easier because you can more easily determine the instance ID from the nodes list.
This patch sets the hostname type to
HostnameTypeResourceNameduring launch template creation. This patch does not introduce configuration options for this change, which keeps the surface area simple and matches my interpretation of the launch template design document.How was this change tested?
Not tested.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.