feat(s2n-quic-dc): mtu probing event subscriber #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…senblum/mtuconfirm # Conflicts: # quic/s2n-quic/src/tests/dc.rs
camshaft
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds an
MtuConfirmCompleteevent subscriber to allow for post handshake probing to complete adcenvironment. The client and server should wait forMtuConfirmCompleteto be ready before closing the connection.Call-outs:
This event subscriber only waits for the local endpoint's MTU probing to be completed. This means that if the connection is closed immediately after
MtuConfirmCompleteis ready, it is possible the other side of the connection may have not completed probing yet. To address this, we may add a new dc frame to indicate probing has completed, but for now the recommendation is to wait for a period of time afterMtuConfirmCompleteis ready before closing.Testing:
Added the event subscriber to the
dcintegration tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.