fix(bindings): prevent temp connection free after panic #5067
+42
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We should never be freeing the temporary connection in
with_context
, even during an unwind. To prevent this make the connectionManuallyDrop
during initialization.Secondly,with_context
may be invoked concurrently, so we should usecontext
notcontext_mut
.Moved to #5701
Testing:
I added a unit test which confirms that the connection is not freed during a panic. I confirmed that the old behavior causes this test to fail.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.