coerce nil numbers to 0 in jmespath codegen #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
commented
Jan 23, 2025
| if v2 != nil && v4 != nil { | ||
| v5 = string(*v2) == string(*v4) | ||
| } | ||
| }else { v5 = v2 == nil && v4 == nil } |
There was a problem hiding this comment.
Yes, gofmt will handle this.
wty-Bryant
approved these changes
Jan 23, 2025
Madrigal
approved these changes
Jan 23, 2025
| )); | ||
| } | ||
|
|
||
| private static boolean isOrderComparator(ComparatorType cmp) { |
There was a problem hiding this comment.
rant (?), non-blocking: I wouldn't know how to name this function so I would get "comparisons excluding direct equality check" without reading inside it. TIL they are technically called "inequalities"link but I'd definitely be thinking != with that name.
(order comparator is fine BTW)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an undocumented quirk in jmespath (as far as i could find) where
nilnumerics are coerced to 0 for order comparison.e.g.
This fixes that in codegen. We caught this while attempting to turn on generated jmespath waiters for
autoscalingin the Go SDK. This will be further verified when those changes are pulled in there.