kvssink - Add Missing Null Checks #1214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirknightj
approved these changes
Dec 18, 2024
unicornss
reviewed
Dec 26, 2024
| @@ -1505,6 +1509,11 @@ init_track_data(GstKvsSink *kvssink) { | |||
|
|
|||
| // extract media type from GstCaps to check whether it's h264 or h265 | |||
| caps = gst_pad_get_allowed_caps(collect_data->pad); | |||
|
|
|||
| if (caps == NULL) { | |||
There was a problem hiding this comment.
can we print caps and also check non empty?
unicornss
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1213
Description of changes:
Add missing null checks in the
init_track_datafunction ofkvssinkto properly handle such cases.Tested by hard-coding each of the values to NULL at the start of the function.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.