Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] NW Socket Support #501

Closed
wants to merge 21 commits into from
Closed

[WIP] NW Socket Support #501

wants to merge 21 commits into from

Conversation

xiazhvera
Copy link

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera changed the title [] [WIP] NW Socket Support Feb 25, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 54.28571% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.35%. Comparing base (590c7b5) to head (42bf9bd).

Files with missing lines Patch % Lines
source/connection.c 54.28% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   79.42%   79.35%   -0.08%     
==========================================
  Files          27       27              
  Lines       11618    11647      +29     
==========================================
+ Hits         9228     9242      +14     
- Misses       2390     2405      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiazhvera xiazhvera marked this pull request as ready for review February 26, 2025 21:22
@xiazhvera xiazhvera changed the base branch from main to nw_socket February 26, 2025 21:22
@xiazhvera xiazhvera marked this pull request as draft February 26, 2025 21:23
@xiazhvera xiazhvera changed the base branch from nw_socket to main February 28, 2025 16:34
@xiazhvera xiazhvera changed the base branch from main to nw_socket February 28, 2025 23:07
@xiazhvera
Copy link
Author

Closed. The PR is used to test and fix nw_socket implementation issue.

@xiazhvera xiazhvera closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants