Let armv8 tests run on new ubuntu-24.04-arm Github runners #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, so check for cross-compile this way instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Github now offers Linux arm64 runners! But when I tried using the
ubuntu-24.04-armrunner in aws-c-common, the unit tests didn't run.Description of changes:
Remove code that assumed linux/armv8 would always be a cross-compile, and therefore shouldn't run tests.
There's code in several other places (1, 2) that stops test from running when builder is actually cross-compiling. I could probably remove similar overrides that set
run_tests = falsefor armv7, armv6, etc in this data.py file ... but I'll keep those as-is for nowBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.