Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the failure when the dynamic loader path is different from the ones in libc #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlbertXingZhang
Copy link

@AlbertXingZhang AlbertXingZhang commented Nov 7, 2024

Issue #, if available:
In Ubuntu 24.04, the dynamic loader path from the ldd command is different from the paths in dpkg-quey.
image
So the current packaging process fails because the packager could not find the dynamic loader.

Description of changes:
The PR changes it to using the dynamic loader from libc if the one from ldd is not found in libc.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marcomagdy
Copy link
Contributor

Careful, this might break in other distros.
We need to find a more reliable way to get the path of the dynamic loader.
Unfortunately, I don't have access to a ubuntu machine (and I don't work at aws anymore). But please, try to see if there's a more robust way of fixing this.

Thank you for the PR.

@AlbertXingZhang
Copy link
Author

Hi @marcomagdy, thanks for your suggestion. I have made a new change to make it use the dynamic loader from libc when the one from ldd is not found in libc. I think it is more robust now.

@AlbertXingZhang AlbertXingZhang changed the title fix the failure when the dynamic loader path is different from the one from libc fix the failure when the dynamic loader path is different from the ones in libc Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants