feat!: improve query to support dynein format #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoneDot
force-pushed
the
improve-query-parse
branch
from
5ac4fde to
92ce166
Compare
StoneDot
force-pushed
the
improve-query-parse
branch
2 times, most recently
from
9a81b4d to
456ef23
Compare
StoneDot
force-pushed
the
improve-query-parse
branch
from
456ef23 to
7eca4dd
Compare
tmyoda
reviewed
Mar 30, 2024
StoneDot
changed the title
StoneDot
force-pushed
the
improve-query-parse
branch
from
5e6eb1e to
df93fa4
Compare
|
@tmyoda Thank you for reviewing thoroughly. Based on your feedback, I updated the commit and commented. Could you please check them? |
StoneDot
force-pushed
the
improve-query-parse
branch
from
465b3c6 to
78e56d8
Compare
StoneDot
force-pushed
the
improve-query-parse
branch
from
78e56d8 to
d75ed8d
Compare
tmyoda
reviewed
Apr 9, 2024
|
@StoneDot Thank you for updating the PR! I have left 2 comments. If you could check them, that would be great. |
tmyoda
reviewed
Apr 11, 2024
This improves the query command to support the dynein format in --sort-key. Improvements contain the following features: * Introduce two formats for --sort-key: strict format and non-strict. * You can now query any condition DynamoDB supports using the strict format. * The non-strict format allows the user less typing and types agnostic input. * The non-strict format retains the same experience as much as possible. * Add --strict and --non-strict options to change the usage of non-strict. * Add configuration option and query.strict_mode to change the default mode. BREAKING CHANGE: Parsing --sort-key is incompatible with the previous one. Signed-off-by: Hiroaki Goto <[email protected]>
StoneDot
force-pushed
the
improve-query-parse
branch
from
d75ed8d to
9a250c3
Compare
|
Thank you for repeatedly making the requested changes! It looks good to me. The changes are well-organized and clear despite the extensive work. I'm impressed by your attention to detail. |
tmyoda
approved these changes
Apr 14, 2024
23 tasks
KIrie-0217
pushed a commit
to KIrie-0217/dynein
that referenced
this pull request
May 15, 2024
This improves the query command to support the dynein format in --sort-key. Improvements contain the following features: * Introduce two formats for --sort-key: strict format and non-strict. * You can now query any condition DynamoDB supports using the strict format. * The non-strict format allows the user less typing and types agnostic input. * The non-strict format retains the same experience as much as possible. * Add --strict and --non-strict options to change the usage of non-strict. * Add configuration option and query.strict_mode to change the default mode. BREAKING CHANGE: Parsing --sort-key is incompatible with the previous one. Signed-off-by: Hiroaki Goto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Implement #163
Description of changes:
This PR improves the parsing for the sort key condition. The current implementation cannot handle the sort key containing spaces. This PR fixes this and provides a way that is compatible with the dynein format.
Improvements contain the following features:
BREAKING CHANGE: Parsing --sort-key is incompatible with the previous one.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.