feat: implement new options into bwrite command #190
Conversation
|
/snapshot |
|
Start taking snapshots for this pull request. |
|
/snapshot |
|
Start taking snapshots for this pull request. |
tmyoda
force-pushed
the
improve-parsing-bwrite
branch
5 times, most recently
from
e00dec6 to
77cfba3
Compare
tmyoda
force-pushed
the
improve-parsing-bwrite
branch
3 times, most recently
from
f1a1076 to
91c2e2e
Compare
tmyoda
force-pushed
the
improve-parsing-bwrite
branch
from
b96b296 to
eb67542
Compare
|
Thank you for the thorough review of this PR. I pushed the changes based on your comment. |
README.md
Outdated
| ``` | ||
|
|
||
| ```bash | ||
| $ dy bwrite --del '{"pk": "1"}' --del '{"pk": "2"}' --put '{"pk": "3", "this_is_set": <<"a","b","c">>}' --input request.json |
There was a problem hiding this comment.
nit: There are two spaces before --input.
README.md
Outdated
| 2 {"this_is_set":["x","y","z"]} | ||
| ``` | ||
|
|
||
| The --put, --del, and --input options can be used simultaneously. |
There was a problem hiding this comment.
nit: Forget to quote backticks.
src/batch.rs
Outdated
| @@ -501,3 +570,68 @@ fn json_binary_val_to_bytes(v: &JsonValue) -> Bytes { | |||
| .expect("binary inputs should be base64 with padding encoded"), | |||
| ) | |||
| } | |||
|
|
|||
| // Check if the item has a partition key and sort key. | |||
| fn validate_item_has_keys( | |||
There was a problem hiding this comment.
This method also checks key types. We need to change the name of this method to reflect actual work. For instance, validate_item_keys makes sense to me.
tmyoda
force-pushed
the
improve-parsing-bwrite
branch
from
498d40a to
0514bee
Compare
tmyoda
force-pushed
the
improve-parsing-bwrite
branch
from
0514bee to
d52a666
Compare
Signed-off-by: Tomoya Oda <[email protected]>
Signed-off-by: Tomoya Oda <[email protected]>
Signed-off-by: Tomoya Oda <[email protected]>
Signed-off-by: Tomoya Oda <[email protected]>
tmyoda
force-pushed
the
improve-parsing-bwrite
branch
from
d52a666 to
5b17141
Compare
|
Thanks for the insightful review. I've fixed the points based on your comment and squashed the fixup commits. |
feat: implement new options into bwrite command --------- Signed-off-by: Tomoya Oda <[email protected]>
Issue #, if available:
#164
Description of changes:
Introduce new options into put command. This commit adds new command options,
--putand--del.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.