Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testutils for gluonts.shell on recent python versions #3234

Closed
wants to merge 2 commits into from

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Nov 5, 2024

Issue #, if available: Running tests for gluonts.shell raises

E   ValueError: mutable default <class 'gluonts.shell.serve.Settings'> for field settings is not allowed: use default_factory

on Python 3.11.

Description of changes: Fix the above issues. Also, one conditional mxnet import fails with an OSError on my machine which is not caught, so I'm adding it to the try/catch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella requested a review from abdulfatir November 5, 2024 00:22
@lostella lostella added bug fix (one of pr required labels) tests This item concerns improving tests and removed bug fix (one of pr required labels) labels Nov 5, 2024
@lostella lostella changed the title Fix gluonts.shell on recent python versions Fix tests for gluonts.shell on recent python versions Nov 5, 2024
@lostella lostella changed the title Fix tests for gluonts.shell on recent python versions Fix testutils for gluonts.shell on recent python versions Nov 5, 2024
@lostella lostella added bug fix (one of pr required labels) pending v0.15.x backport This contains a fix to be backported to the v0.15.x branch pending v0.16.x backport This contains a fix to be backported to the v0.16.x branch labels Nov 5, 2024
@lostella lostella removed pending v0.15.x backport This contains a fix to be backported to the v0.15.x branch pending v0.16.x backport This contains a fix to be backported to the v0.16.x branch labels Nov 5, 2024
@lostella
Copy link
Contributor Author

lostella commented Nov 5, 2024

Superseded by fixes in #3228

@lostella lostella closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix (one of pr required labels) tests This item concerns improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants