Skip to content

Commit

Permalink
Use separate endpoint URLs for benchmark CI (#1112)
Browse files Browse the repository at this point in the history
## Description of change

This allows integration test workflows and benchmark workflows to run
against different endpoint URLs.

## Does this change impact existing behavior?

No, only CI change.

## Does this change need a changelog entry in any of the crates?

No

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

Signed-off-by: Monthon Klongklaew <[email protected]>
  • Loading branch information
monthonk authored Nov 8, 2024
1 parent c4ec299 commit 7d01885
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ env:
S3_BUCKET_BENCH_FILE: ${{ vars.BENCH_FILE_NAME || 'bench100GB.bin' }}
S3_BUCKET_SMALL_BENCH_FILE: ${{ vars.SMALL_BENCH_FILE_NAME || 'bench5MB.bin' }}
# Optional endpoint url, can be empty
S3_ENDPOINT_URL: ${{ vars.S3_ENDPOINT_URL }}
S3_ENDPOINT_URL: ${{ vars.S3_BENCH_ENDPOINT_URL }}
S3_REGION: ${{ vars.S3_BENCH_REGION }}

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bench_s3express.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ env:
S3_BUCKET_BENCH_FILE: ${{ vars.BENCH_FILE_NAME || 'bench100GB.bin' }}
S3_BUCKET_SMALL_BENCH_FILE: ${{ vars.SMALL_BENCH_FILE_NAME || 'bench5MB.bin' }}
# Optional endpoint url, can be empty
S3_ENDPOINT_URL: ${{ vars.S3_EXPRESS_ONE_ZONE_ENDPOINT_URL }}
S3_ENDPOINT_URL: ${{ vars.S3_EXPRESS_ONE_ZONE_BENCH_ENDPOINT_URL }}
S3_REGION: ${{ vars.S3_BENCH_REGION }}

jobs:
Expand Down

0 comments on commit 7d01885

Please sign in to comment.