Resolve clippy errors introduced in Rust 1.78.0 (#865)

Address 2 issues: * Assigning clones (https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones) Use `clone_into()` instead of assigning the result of `ToOwned::to_owned()` or `Clone::clone()`. * Remove the unused `mountpoint-s3-client::util::PtrExt` Redundant. Similar functionality now in `mountpoint-s3-crt::CrtError`. Signed-off-by: Alessandro Passaro <[email protected]>
awslabs · May 3, 2024 · 9d22f1f · 9d22f1f
1 parent e32f890
commit 9d22f1f
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 27 deletions.
diff --git a/mountpoint-s3-client/src/endpoint_config.rs b/mountpoint-s3-client/src/endpoint_config.rs
@@ -79,7 +79,7 @@ impl EndpointConfig {
     /// Set region for a given endpoint config
     #[must_use = "EndpointConfig follows a builder pattern"]
     pub fn region(mut self, region: &str) -> Self {
-        self.region = region.to_owned();
+        region.clone_into(&mut self.region);
         self
     }
 

diff --git a/mountpoint-s3-client/src/lib.rs b/mountpoint-s3-client/src/lib.rs
@@ -56,7 +56,6 @@ mod object_client;
 mod s3_crt_client;
 #[doc(hidden)]
 pub mod user_agent;
-mod util;
 
 pub use object_client::{ObjectClient, PutObjectRequest};
 

diff --git a/mountpoint-s3-client/src/mock_client.rs b/mountpoint-s3-client/src/mock_client.rs
@@ -730,7 +730,7 @@ impl ObjectClient for MockClient {
                         };
                         result.object_parts = parts;
                     }
-                    ObjectAttribute::StorageClass => result.storage_class = object.storage_class.clone(),
+                    ObjectAttribute::StorageClass => object.storage_class.clone_into(&mut result.storage_class),
                     ObjectAttribute::ObjectSize => result.object_size = Some(object.size as u64),
                 }
             }

diff --git a/mountpoint-s3-client/src/util.rs b/mountpoint-s3-client/src/util.rs