Create file-system-benchmarks.rs and update fs_latency_bench.sh accordingly #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dingly Signed-off-by: Renan Magagnin <[email protected]>
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
requested changes
Jan 9, 2025
Comment on lines
+19
to
+20
| #[derive(Parser, Debug)] | ||
| struct CliArgs { |
There was a problem hiding this comment.
What's the purpose of this tool? We can add a description using rustdoc, and it'll also end up in the binary.
Suggested change
| #[derive(Parser, Debug)] | |
| struct CliArgs { | |
| /// Benchmark tool for measuring the time of Linux file system operations. | |
| #[derive(Parser, Debug)] | |
| struct CliArgs { |
In particular, it's probably worth clarifying that this tool can only measure the time end-to-end rather than looking at FUSE operations.
There was a problem hiding this comment.
Added. I figured it's best not to include the mentioned clarification since it is possible to enable a breakdown of operation specific latencies with the --detailed flag. Let me know if I misunderstood!
There was a problem hiding this comment.
I think the current desc is fine - I was trying to highlight that it specifically won't be able to measure a FUSE open, since we cannot trigger them independently.
Signed-off-by: Renan Magagnin <[email protected]>
renanmagagnin
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
renanmagagnin
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
renanmagagnin
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
renanmagagnin
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Renan Magagnin <[email protected]>
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
renanmagagnin
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of a benchmarking binary for recreating and measuring the latencies of real-world usage patterns of Mountpoint. This version includes only a small file creation benchmark which measures the sequence of the file system operations: lookup, open, write (of one byte), and flush. The latency measurement captures the total duration and is averaged multiple iterations to ensure representativeness.
The benchmarking binary is used in the
fs_latency_bench.shscript and the the new results are included in the final results of the script, ultimately being added to the benchmarking GitHub pages dashboard.Does this change impact existing behavior?
No.
Does this change need a changelog entry?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).