Fix Clippy warnings on Rust 1.84 #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
previously approved these changes
Jan 10, 2025
Rust 1.84 has just released and with it, new clippy lints have been added. This PR fixes these issues. Signed-off-by: Simon Beal <[email protected]>
Signed-off-by: Simon Beal <[email protected]>
muddyfish
force-pushed
the
clippy-rust-1.34
branch
from
685840d to
a09a46f
Compare
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
keremnc
pushed a commit
to keremnc/mountpoint-s3
that referenced
this pull request
Jan 24, 2025
Rust 1.84 has just released and with it, new clippy lints have been added. We're also updating to Rust 1.84 explicitly rather than returning to stable to avoid the issues we had with the most recent release ### Does this change impact existing behavior? No ### Does this change need a changelog entry? No --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Simon Beal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.84 has just released and with it, new clippy lints have been added.
We're also updating to Rust 1.84 explicitly rather than returning to stable to avoid the issues we had with the most recent release
Does this change impact existing behavior?
No
Does this change need a changelog entry?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).