Improve the instructions to add benchmark files manually #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HMARKING.md Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
suggested changes
Oct 6, 2023
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
suggested changes
Oct 9, 2023
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
monthonk
reviewed
Oct 10, 2023
doc/BENCHMARKING.md
Outdated
| aws s3 cp your_local_dir/your_file_name s3://${S3_BUCKET_NAME}/${S3_BUCKET_TEST_PREFIX} | ||
| 3. Create the bench files manually in your S3 bucket. You can do that by mounting the bucket on your machine using Mountpoint. Then, running fio jobs against your mount directory to let fio create the files for you. | ||
|
|
||
| MOUNT_DIR = path/to/mount |
There was a problem hiding this comment.
nit: remove the space.
Suggested change
| MOUNT_DIR = path/to/mount | |
| MOUNT_DIR=path/to/mount |
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the instructions to add benchmark files manually in doc/BENCHMARKING.md.
Description of change
As write is enabled on mountpoint, easiest way to manually add benchmark files is using fio on mounted directory for the bucket. Also, added instruction for adding directories for
readdirworkload using fio.Relevant issues:
NA
Does this change impact existing behavior?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).