Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused generic in DataCache #589

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

dannycjones
Copy link
Contributor

Description of change

It's just making things complicated at the moment.

Does this change impact existing behavior?

No breaking change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Daniel Carl Jones <[email protected]>
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one note on a comment.

mountpoint-s3/src/data_cache.rs Outdated Show resolved Hide resolved
Signed-off-by: Daniel Carl Jones <[email protected]>
@dannycjones dannycjones temporarily deployed to PR integration tests October 31, 2023 15:37 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests October 31, 2023 15:37 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests October 31, 2023 15:37 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests October 31, 2023 15:37 — with GitHub Actions Inactive
@dannycjones dannycjones requested a review from passaro October 31, 2023 15:38
@dannycjones dannycjones enabled auto-merge October 31, 2023 15:38
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannycjones dannycjones added this pull request to the merge queue Oct 31, 2023
Merged via the queue into awslabs:main with commit 404ba9c Oct 31, 2023
16 of 18 checks passed
@dannycjones dannycjones deleted the remove-data-cache-generic branch October 31, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants